Downcase BufferedObjectOperations and clarify its scope#417
Merged
lawrence-forooghian merged 1 commit intomainfrom Jan 23, 2026
Merged
Downcase BufferedObjectOperations and clarify its scope#417lawrence-forooghian merged 1 commit intomainfrom
BufferedObjectOperations and clarify its scope#417lawrence-forooghian merged 1 commit intomainfrom
Conversation
Make it clear it's an instance attribute of the RealtimeObjects instance, and make its name look like an attribute name (as opposed to a class name).
VeskeR
approved these changes
Jan 23, 2026
Contributor
VeskeR
left a comment
VeskeR
left a comment
There was a problem hiding this comment.
Not really against the change, I just wonder if we're not restricting SDK implementation freedom too much by telling them exactly what internal attributes they should have.
If we go ahead with this, we might as well update the same for SyncObjectsPool.
Collaborator
Author
|
I'm not sure there's a huge difference between saying "it needs to maintain this data structure" and "it needs to have an attribute with this name"; they're both pretty prescriptive and given it's internal people can do what they want anyway. cf e.g. the RTN16f
Yeah, I was thinking about this; ended up keeping it the same just for consistency with presence |
lawrence-forooghian
deleted the
clarify-BufferedObjectsOperations-scope
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it clear it's an instance attribute of the
RealtimeObjectsinstance, and make its name look like an attribute name (as opposed to a class name).